Miretpl commented on PR #61957: URL: https://github.com/apache/airflow/pull/61957#issuecomment-4050452946
> Okay, I understood the general approach was actually to move all parameters into the specific workers.celery/workers.kubernetes sections At the beginning, I think the general approach was to make this common parachute over the celery/kubernetes (as it was somewhere in the related issue), and at the beginning, it didn't add complexity to the chart really. The situation changed dramatically after the Worker Set feature, which made everything much more complex. > But keeping multiple parameters in multiple sections in my view render a lot of complexity of respecting two locations. I agree that having a common parachute will be more complex from the template perspective, and also, after all, the chart user can just duplicate the value between places if there is a need for the same config for both worker types. At the end, having this complexity might not be worth the effort. > Would rather propose to make it lean and clear. Agreed. I will make a separate PR for already merged sections with the deprecation of them. Regarding this PR, I can include deprecation in the follow-up or add it here for nodeSelector tomorrow/or during the weekend, so feel free to merge/not merge it in the current state -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
