anishgirianish opened a new pull request, #63491:
URL: https://github.com/apache/airflow/pull/63491
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
## Summary
Refactors executor workload queue management for extensibility. No
behavioral change , scheduling order, slot accounting, and all provider
executors work identically to before.
Follows the direction proposed by @ferruzzi
https://github.com/apache/airflow/pull/62343#discussion_r2127826554.
## Problem
Adding a new workload type (like ExecuteCallback or TestConnection) required
touching ~6 places in BaseExecutor: a new queue dict, a new `supports_*`
flag,slots calculation, an isinstance branch in queue_workload, a dedicated
scheduling method, and isinstance branches in dequeue/trigger logic. Each
provider executor that overrode `queue_workload` also needed updating. This
made extending the executor interface unnecessarily painful.
## What this does
Replaces the per-type queue dicts and boolean capability flags with three
simple primitives:
- `executor_queues` : a single dict keyed by workload type string (e.g.
`"ExecuteTask"`, `"ExecuteCallback"`) instead of separate `queued_tasks`,
`queued_callbacks`, `queued_connection_tests` dicts
- `supported_workload_types` : a frozenset of type strings instead of
iindividual `supports_callbacks`, `supports_connection_test` booleans
- `WorkloadQueueDef(scheduling_tier, sort_key)`, a small NamedTuple on each
workload class that controls scheduling priority. Callbacks get tier 0, tasks
get tier 1, same order as before, just explicit now.
The base class `queue_workload` is now generic: validate the type, store by
key. Four provider executors (K8s, ECS, Batch, Lambda) no longer need their own
`queue_workload` overrides. `trigger_tasks` becomes `trigger_workloads` since
it handles all workload types now.
## Adding a new workload type after this refactor
1. Define `key` and `queue_def` on the workload dataclass
2. Add the type string to `supported_workload_types` on supporting executors
3. Handle the type in `_process_workloads` done
No changes needed in BaseExecutor itself.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
