jscheffl commented on code in PR #63482:
URL: https://github.com/apache/airflow/pull/63482#discussion_r2927995499
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -184,8 +185,7 @@ def __init__(self, parallelism: int = PARALLELISM,
team_name: str | None = None)
self.parallelism: int = parallelism
self.team_name: str | None = team_name
- self.queued_tasks: dict[TaskInstanceKey, workloads.ExecuteTask] = {}
- self.queued_callbacks: dict[str, workloads.ExecuteCallback] = {}
+ self.executor_queues: dict[str, dict] = defaultdict(dict)
Review Comment:
I am not sure and have not taken a deep look into the potential
simplification but you are renaming fields in the BaseExecutor class which all
Executors inherit on.
Yes, the fields are adjusted in the PR from executors. But you can mix the
versions of providers, upgrade Airflow core and leave providers in old versions
(actually this is a best practice in upgrading not to have complexity in
triage) and you can also upgrade providers when you keep the same core version.
In any of these two the renamed fields break the executors. So renaming the
fields (and semantic how the fields are used) is breaking the (public)
interface for executors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
