OmerJog commented on a change in pull request #6489: [AIRFLOW-3959]
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r358643935
##########
File path: airflow/models/dag.py
##########
@@ -1384,7 +1390,8 @@ def sync_to_db(self, owner=None, sync_time=None,
session=None):
orm_dag.default_view = self._default_view
orm_dag.description = self.description
orm_dag.schedule_interval = self.schedule_interval
- session.merge(orm_dag)
+ orm_dag.tags = self.get_dagtags(session=session)
Review comment:
Why does it need JSON column?
If table is on DAG level... each row represent dag then labels are just
dimension on this DAG. It can be array type.
Each change in label affect only 1 DAG so it's just updating one cell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
