anishgirianish commented on code in PR #63491:
URL: https://github.com/apache/airflow/pull/63491#discussion_r2928505436
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -184,8 +185,7 @@ def __init__(self, parallelism: int = PARALLELISM,
team_name: str | None = None)
self.parallelism: int = parallelism
self.team_name: str | None = team_name
- self.queued_tasks: dict[TaskInstanceKey, workloads.ExecuteTask] = {}
- self.queued_callbacks: dict[str, workloads.ExecuteCallback] = {}
+ self.executor_queues: dict[str, dict] = defaultdict(dict)
Review Comment:
Tried expanding to a precise type, but workloads.All includes RunTrigger
(which lacks queue_key/sort_key), causing union-attr errors in base_executor
and return-value mismatches in hybrid executors like LocalKubernetesExecutor
that expect dict[TaskInstanceKey, ...]. Each workload type uses different
key/value types, so a single generic annotation doesn't fit without spreading
type: ignore comments. Would really appreciate any suggestions you might have
for a cleaner approach. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
