This is an automated email from the ASF dual-hosted git repository.
choo121600 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 672bfe8c541 feat: Improve Playwright test patterns in
home-dashboard.spec.ts (#63448)
672bfe8c541 is described below
commit 672bfe8c541e09f196b647a16656843058cb77ed
Author: Desel72 <[email protected]>
AuthorDate: Thu Mar 12 22:09:07 2026 -0500
feat: Improve Playwright test patterns in home-dashboard.spec.ts (#63448)
---
airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts | 8 ++++----
.../src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts | 8 ++------
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts
b/airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts
index 4471bf4ddc2..672a6fab612 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-import type { Locator, Page } from "@playwright/test";
+import { expect, type Locator, type Page } from "@playwright/test";
import { BasePage } from "tests/e2e/pages/BasePage";
/**
@@ -57,7 +57,7 @@ export class HomePage extends BasePage {
this.failedDagsCard = page.locator('a[href*="last_dag_run_state=failed"]');
this.runningDagsCard =
page.locator('a[href*="last_dag_run_state=running"]');
this.activeDagsCard = page.locator('a[href*="paused=false"]');
- this.dagImportErrorsCard = page.locator('button:has-text("DAG Import
Errors")');
+ this.dagImportErrorsCard = page.getByRole("button", { name: "DAG Import
Errors" });
// Stats section - using role-based selector
this.statsSection = page.getByRole("heading", { name: "Stats"
}).locator("..");
@@ -120,7 +120,7 @@ export class HomePage extends BasePage {
* Wait for dashboard to fully load
*/
public async waitForDashboardLoad(): Promise<void> {
- await this.welcomeHeading.waitFor({ state: "visible", timeout: 30_000 });
+ await expect(this.welcomeHeading).toBeVisible({ timeout: 30_000 });
}
/**
@@ -128,7 +128,7 @@ export class HomePage extends BasePage {
*/
// eslint-disable-next-line @typescript-eslint/class-methods-use-this
private async getStatsCardCount(card: Locator): Promise<number> {
- await card.waitFor({ state: "visible" }); // Fail fast if card doesn't
exist
+ await expect(card).toBeVisible();
const badgeText = await card.locator("span").first().textContent();
const match = badgeText?.match(/\d+/);
diff --git a/airflow-core/src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts
b/airflow-core/src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts
index 8ebcff00ea5..847a63058ab 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts
@@ -67,17 +67,13 @@ test.describe("Dashboard Metrics Display", () => {
await homePage.waitForDashboardLoad();
await homePage.activeDagsCard.click();
- await homePage.page.waitForURL(/paused=false/);
-
- expect(homePage.page.url()).toContain("paused=false");
+ await expect(homePage.page).toHaveURL(/paused=false/);
await homePage.navigate();
await homePage.waitForDashboardLoad();
await homePage.runningDagsCard.click();
- await homePage.page.waitForURL(/last_dag_run_state=running/);
-
- expect(homePage.page.url()).toContain("last_dag_run_state=running");
+ await expect(homePage.page).toHaveURL(/last_dag_run_state=running/);
});
test("should display welcome heading on dashboard", async () => {
