uranusjr commented on code in PR #62509:
URL: https://github.com/apache/airflow/pull/62509#discussion_r2929030945
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -376,21 +375,30 @@ def _queue_dagruns(
@classmethod
def _queue_partitioned_dags(
cls,
+ *,
asset_id: int,
partition_dags: Iterable[DagModel],
event: AssetEvent,
partition_key: str | None,
+ task_instance: TaskInstance | None,
session: Session,
) -> None:
if partition_dags and not partition_key:
- # TODO: AIP-76 how to best ensure users can see this? Probably add
Log record.
- log.warning(
- "Listening Dags are partition-aware but run has no partition
key",
- listening_dags=[x.dag_id for x in partition_dags],
- asset_id=asset_id,
- run_id=event.source_run_id,
- dag_id=event.source_dag_id,
- task_id=event.source_task_id,
+ msg = (
+ f"Listening Dags are partition-aware but the run has no
partition key "
+ f"(listening_dags={[x.dag_id for x in partition_dags]}, "
+ f"asset_id={asset_id}, "
+ f"run_id={event.source_run_id}, "
+ f"dag_id={event.source_dag_id}, "
+ f"task_id={event.source_task_id})"
+ )
+ log.warning(msg)
Review Comment:
This loses structured log. Probably better to separate the log call and
models.Log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
