potiuk commented on code in PR #63495: URL: https://github.com/apache/airflow/pull/63495#discussion_r2930837953
########## AGENTS.md: ########## @@ -85,6 +85,7 @@ UV workspace monorepo. Key paths: - In `airflow-core`, functions with a `session` parameter must not call `session.commit()`. Use keyword-only `session` parameters. - Imports at top of file. Valid exceptions: circular imports, lazy loading for worker isolation, `TYPE_CHECKING` blocks. - Guard heavy type-only imports (e.g., `kubernetes.client`) with `TYPE_CHECKING` in multi-process code paths. +- Define dedicated exception classes instead of raising the broad `AirflowException` directly. Each error case should have a specific exception type that conveys what went wrong. Review Comment: ```suggestion - Define dedicated exception classes or use existing exceptions such as `ValueError` instead of raising the broad `AirflowException` directly. Each error case should have a specific exception type that conveys what went wrong. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
