eladkal commented on code in PR #63518:
URL: https://github.com/apache/airflow/pull/63518#discussion_r2931283094


##########
providers/databricks/pyproject.toml:
##########
@@ -64,6 +64,7 @@ dependencies = [
     "requests>=2.32.0,<3",
     "databricks-sql-connector>=4.0.0",
     "aiohttp>=3.9.2, <4",
+    "aiofiles>=23.2.0",

Review Comment:
   See example of how we handle such cases:
   
https://github.com/apache/airflow/blob/702b51a7d4b8386e20a0646b299fbe618ca897d3/providers/standard/src/airflow/providers/standard/operators/python.py#L408-L417
   
   
https://github.com/apache/airflow/blob/4d3c5ead3b570f9c6a395d7aa63d856270fc5619/providers/apache/impala/src/airflow/providers/apache/impala/hooks/impala.py#L54-L60
   
   
https://github.com/apache/airflow/blob/4d3c5ead3b570f9c6a395d7aa63d856270fc5619/providers/vertica/src/airflow/providers/vertica/hooks/vertica.py#L143-L149
   
   We can't install everything on every provider. That would be madness.
   Only things you actually need should be installed.
   The last thing user should face is solving pip conflicts about packages he 
doesn't even need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to