pierrejeambrun commented on code in PR #62583: URL: https://github.com/apache/airflow/pull/62583#discussion_r2931313356
########## airflow-core/src/airflow/api_fastapi/core_api/routes/ui/deadlines.py: ########## @@ -17,24 +17,104 @@ from __future__ import annotations -from typing import Annotated +from datetime import datetime +from typing import Annotated, cast -from fastapi import Depends, HTTPException, status +from fastapi import Depends, HTTPException, Query, status from sqlalchemy import select from sqlalchemy.orm import joinedload from airflow.api_fastapi.auth.managers.models.resource_details import DagAccessEntity from airflow.api_fastapi.common.db.common import SessionDep, paginated_select from airflow.api_fastapi.common.parameters import QueryLimit, QueryOffset, SortParam from airflow.api_fastapi.common.router import AirflowRouter -from airflow.api_fastapi.core_api.datamodels.ui.deadline import DeadlineCollectionResponse +from airflow.api_fastapi.core_api.datamodels.ui.deadline import ( + DeadlineAlertCollectionResponse, + DeadlineCollectionResponse, + DeadlineWithDagRunCollectionResponse, +) from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc -from airflow.api_fastapi.core_api.security import requires_access_dag +from airflow.api_fastapi.core_api.security import ReadableDagsFilterDep, requires_access_dag from airflow.models.dagrun import DagRun from airflow.models.deadline import Deadline from airflow.models.deadline_alert import DeadlineAlert +from airflow.models.serialized_dag import SerializedDagModel +all_deadlines_router = AirflowRouter(prefix="/deadlines", tags=["Deadlines"]) Review Comment: We shouldn't add multiple routers like this because it's not needed and that is not how we handle this for other sub resources. Also all_dealines_router vs deadlines_router is not great. This is equivalent to both wildcard ~ for dag_id and dag_run_id -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
