Shnekit commented on code in PR #62962: URL: https://github.com/apache/airflow/pull/62962#discussion_r2932011891
########## providers/amazon/docs/index.rst: ########## @@ -123,7 +123,7 @@ PIP package Version required ``asgiref`` ``>=2.3.0`` ``PyAthena`` ``>=3.10.0`` ``jmespath`` ``>=0.7.0`` -``sagemaker-studio`` ``>=1.0.9`` +``sagemaker-studio`` ``>=1.0.25,<1.1.0`` Review Comment: Yes, I can push this to mainline, so that it goes out to latest SDK in the next release ########## providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio.py: ########## @@ -43,7 +43,10 @@ This test will emulate a DAG run in the shared MWAA environment inside a SageMaker Unified Studio Project. The setup tasks will set up the project and configure the test runner to emulate an MWAA instance. -Then, the SageMakerNotebookOperator will run a test notebook. This should spin up a SageMaker training job, run the notebook, and exit successfully. +Then, the SageMakerNotebookOperator will run a test notebook twice: + 1. With all environment variables set (legacy MWAA-style, for SDK backwards compatibility) + 2. With domain_id/project_id passed explicitly as operator parameters and no environment variables Review Comment: Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
