pierrejeambrun commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r2932356638
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -174,6 +189,70 @@ def bulk_connections(
return BulkConnectionService(session=session,
request=request).handle_request()
+@connections_router.patch(
+ "/{connection_id}/test",
+ responses=create_openapi_http_exception_doc(
+ [
+ status.HTTP_400_BAD_REQUEST,
+ status.HTTP_403_FORBIDDEN,
+ status.HTTP_404_NOT_FOUND,
+ ]
+ ),
+ dependencies=[Depends(requires_access_connection(method="PUT")),
Depends(action_logging())],
+)
+def patch_connection_and_test(
Review Comment:
I believe this should be `patch_connection_test` only or even removed, it's
confusing. A single `async_test_connection` endpoint should be enough. (We can
deduce if it's an edit or insert by fetching the db)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
