bittoby opened a new pull request, #63559:
URL: https://github.com/apache/airflow/pull/63559
Replace Playwright anti-patterns with web-first assertions in
`dags-list.spec.ts` and `DagsPage.ts` to align with Playwright best practices.
No test coverage or behavior changes.
- Remove all `waitForTimeout()` calls — replaced with state-based waiting
(`expect().toBeVisible/Hidden/toHaveCount`, `waitForResponse`)
- Replace CSS `:has-text()` and `locator("text=")` with `getByRole()`,
`getByTestId()`, and `.filter({ hasText: })`
- Convert boolean-returning verify methods (`verifyDagExists`,
`verifyCardViewVisible`, `verifyTableViewVisible`) to `Promise<void>` with
web-first `expect()` assertions
- Replace `while` loop + `waitForTimeout` polling in `verifyDagRunStatus`
with `expect.poll()`
- Fix broken `needsReviewFilter` selector (`button:has-text("Needs Review")`
→ `getByTestId("dags-needs-review-filter")`)
closes: #63426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
