Dev-iL opened a new pull request, #63587:
URL: https://github.com/apache/airflow/pull/63587
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Summary
`airflowctl` was generating CLI options for boolean fields with both:
- `action=argparse.BooleanOptionalAction`
- `type=bool`
On Python 3.14, `argparse.BooleanOptionalAction` no longer accepts the
`type` keyword, which caused parser construction to fail with:
```text
TypeError: BooleanOptionalAction.__init__() got an unexpected keyword
argument 'type'
```
This change updates `Arg.add_to_parser()` to drop `type` when the argument
uses `BooleanOptionalAction`, while leaving the existing generated argument
metadata unchanged.
## Why this approach
The fix is applied at the final parser handoff point rather than changing
every code path that creates boolean arguments. That keeps the behavior
centralized and preserves the existing test expectations around generated `Arg`
objects.
This is backward compatible with older Python versions because
`BooleanOptionalAction` is a flag action and does not consume a value that
would need type conversion.
## Tests
- Added a regression test that exercises `Arg.add_to_parser()` with
`BooleanOptionalAction`
- Verified with:
```bash
pytest airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py -xvs
```
## References
- Python 3.14 `argparse.py`:
https://raw.githubusercontent.com/python/cpython/3.14/Lib/argparse.py
- Python 3.12 `argparse.py`:
https://raw.githubusercontent.com/python/cpython/3.12/Lib/argparse.py
- Updated code:
[`airflow-ctl/src/airflowctl/ctl/cli_config.py`](/home/iliya/repositories/airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py)
- Regression test:
[`airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py`](/home/iliya/repositories/airflow/airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Codex gpt-5.4 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
