mango766 opened a new pull request, #63594:
URL: https://github.com/apache/airflow/pull/63594

   ## Summary
   
   When `remote_task_handler_kwargs` is configured with `FileTaskHandler` 
parameters like `max_bytes`, `backup_count`, or `delay`, these were incorrectly 
merged into `RemoteLogIO` constructors (S3, GCS, WASB, OSS, HDFS, CloudWatch), 
causing a `TypeError` because those classes don't accept handler-level 
parameters. After construction, `remote_task_handler_kwargs` was reset to `{}`, 
so the `FileTaskHandler` logging config update at the end of the file never 
received those parameters either.
   
   This fix separates the kwargs upfront into two groups:
   - **handler_kwargs**: `FileTaskHandler` parameters (`max_bytes`, 
`backup_count`, `delay`) applied to `DEFAULT_LOGGING_CONFIG["handlers"]["task"]`
   - **remote_io_kwargs**: all other parameters passed to the `RemoteLogIO` 
constructor
   
   This restores the Airflow 2.x behavior where `remote_task_handler_kwargs` 
could configure `FileTaskHandler` parameters like log file size limits.
   
   closes: #58770
   
   ## Test plan
   
   - [x] Added parametrized unit tests verifying the kwargs separation logic
   - [ ] Manual verification: configure `remote_task_handler_kwargs = 
{"max_bytes": 5000000, "backup_count": 5}` with WASB remote logging and confirm 
no `TypeError` on startup
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (claude-opus-4-6)
   
   Generated-by: Claude Code (claude-opus-4-6) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to