yuseok89 commented on code in PR #63523:
URL: https://github.com/apache/airflow/pull/63523#discussion_r2935345135
##########
providers/slack/src/airflow/providers/slack/hooks/slack.py:
##########
@@ -310,6 +310,12 @@ def send_file_v1_to_v2(
else:
channels_to_share = [None]
+ if thread_ts is not None and len(channels_to_share) > 1:
+ raise ValueError(
+ "thread_ts cannot be used with multiple channels. "
+ "A thread belongs to a single channel; specify exactly one
channel when replying in a thread."
+ )
Review Comment:
As I mentioned earlier (the part about sending DMs), we can use a User ID to
open a DM, and similarly we can use a DM channel ID (starting with D) in the
channel parameter.
In both cases, the term "channel" here includes DM conversations.
The validation only checks that channels has a single value and does not
distinguish between channels and DMs.
DM thread replies pass the validation as expected.
If I've misunderstood your concern, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
