shivaam commented on PR #63599: URL: https://github.com/apache/airflow/pull/63599#issuecomment-4060848204
> > PR checklist already requires running static checks before pushing. Wouldn't running those once before commit/PR be sufficient rather than after every file edit? Curious if there's a specific failure mode this is targeting that the batch approach doesn't catch. > > Yes - ruff is VERY fast and can be done immediately, on the other hand runnig `prek` for the change takes a bit of time and often what happens when you run the checks after edit they fail first and then the agent looks at the output, re-adds the file and re-runs prek check. This takes usually a bit less than minute more for re-run and I get it practically every time when some files were edited. > > By adding ruff at modification time - when everything else is fine, this will result in no rerun needed. So `prek` will only be run once and succeed. So this is rally an optimisation of speed of processing. That makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
