henry3260 commented on PR #63575: URL: https://github.com/apache/airflow/pull/63575#issuecomment-4060960995
Thanks for your PR! While reviewing this, I thought of a couple of edge cases regarding the `timeout `parameter: 1. User set timeout over 604800 2. User set timeout to a negative number Should we add some validation logic to raise a `ValueError `for negative numbers and either cap the value at 604800 (with a warning) or raise an error if it exceeds the max limit? This would help us fail fast and provide a better error message to the users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
