Vamsi-klu commented on PR #62656: URL: https://github.com/apache/airflow/pull/62656#issuecomment-4061296780
Hi @jscheffl, thank you for the careful review and for catching this. You're absolutely right — the KubernetesHook changes (`_ensure_exec_plugin_cache_dirs` for issue #60943) were unrelated to the structlog fix and should not have been part of this PR. They were not hallucinated code, but they were mistakenly committed to this branch instead of their own. I've removed those commits from this PR. The branch now contains only the two structlog-related commits: 1. **`6a6d698`** — The core fix: wrap `enc_hook` with a `safe_default` fallback that catches `TypeError` and falls back to `str()` 2. **`7bd90e2`** — Review feedback: hoist the closure into a module-level factory `_make_safe_enc_hook()`, and add three targeted tests The KubernetesHook fix will be submitted as a separate PR. Apologies for the noise, and thank you again for flagging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
