gopidesupavan opened a new pull request, #63615:
URL: https://github.com/apache/airflow/pull/63615
Import error updates in dag processing were matching DagModel rows by
relative_fileloc only. When two DAG bundles contained files with the same
relative path, an import error in one bundle could incorrectly mark the other
bundle’s DAG as having import errors and even overwrite its bundle_name.
This is easily reproducible:
1. Configure two DAG bundles that contain the same relative file name, for
example:
files/bundle_a/example_dag.py
files/bundle_b/example_dag.py
2. Set the bundle config:
export AIRFLOW__DAG_PROCESSOR__DAG_BUNDLE_CONFIG_LIST='[
{"name":"bundle_a","classpath":"airflow.dag_processing.bundles.local.LocalDagBundle","kwargs":{"path":"/files/bundle_a","refresh_interval":0}},
{"name":"bundle_b","classpath":"airflow.dag_processing.bundles.local.LocalDagBundle","kwargs":{"path":"/files/bundle_b","refresh_interval":0}}
]'
3. Parse both bundles successfully:
4. Introduce an import error only in files/bundle_a/example_dag.py.
5. Reparse only bundle_a
`airflow dags reserialize --bundle-name bundle_a`
```
select dag_id, bundle_name, relative_fileloc, has_import_errors
from dag
where relative_fileloc = 'example_dag.py'
order by bundle_name, dag_id;
```
Before this fix, you can end up with both records marked as having import
errors, even though only the DAG in bundle_a is broken.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
