jscheffl commented on code in PR #52156: URL: https://github.com/apache/airflow/pull/52156#discussion_r2936722348
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -170,11 +170,14 @@ SIMPLE_AUTH_MANAGER = "SimpleAuthManager" FAB_AUTH_MANAGER = "FabAuthManager" +GOLANG_WORKER = "go" + DEFAULT_ALLOWED_EXECUTOR = ALLOWED_EXECUTORS[0] ALLOWED_AUTH_MANAGERS = [SIMPLE_AUTH_MANAGER, FAB_AUTH_MANAGER] START_AIRFLOW_ALLOWED_EXECUTORS = [LOCAL_EXECUTOR, CELERY_EXECUTOR, EDGE_EXECUTOR] START_AIRFLOW_DEFAULT_ALLOWED_EXECUTOR = START_AIRFLOW_ALLOWED_EXECUTORS[0] ALLOWED_CELERY_EXECUTORS = [CELERY_EXECUTOR, CELERY_K8S_EXECUTOR] +ALLOWED_WORKER_TYPES = [GOLANG_WORKER] Review Comment: Why should we? I think if you want to test EdgeExecutor it would be always required to have one worker. I see low benefit of adding this to an extra parameter because there would be almost no use case starting without. So I'd say: No... until there is a benefit in this. In my view a Go worker is something additional but I see no real use case where you only start a Go worker and no other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
