justinpakzad opened a new pull request, #63665:
URL: https://github.com/apache/airflow/pull/63665
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
Currently the the PATCH dags endpoint uses the
QueryDagIdPatternSearchWithNone for the dag_id_pattern which has `skip_none =
False`, meaning if we try to pause/unpause via tags or owners it won't work
unless a value for dag_id_pattern is passed as well. This seems intentional as
we wouldn't want users to accidently unpause or pause all of their dags if they
mistakenly don't pass in any filters/query-params but it does pose limitations
- one of them being if I try to provide the following params to the request:
`params={
"update_mask": ["is_paused"],
"tags": ["loader"],
"tags_match_mode": "any"
}`
no dags would be paused even though I have dags tagged with loader. If that
is the intended behavior then that's fine we should probably just update the
documentation so that's clear.
The changes I'm proposing would still have the "safeguard" in place by
checking if the dag_id_pattern, tags, or owners filters were passed and if not
it would do something similar to what it does now and just not PATCH any of the
dags. With this guard in place, we can use the existing QueryDagIdPatternSearch
(which has `skip_none=True`) instead. This allows patching dags by tags,
owners, or dag_id patterns independently.
closes: #50555
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Claude Sonnet 4.5 (mainly for generating test dags)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
