r-richmond commented on PR #63677: URL: https://github.com/apache/airflow/pull/63677#issuecomment-4064073198
> I assume mostly the given documentation does not cater for this. I assume we should rather invest in a proper mechanism to have dashboard alerts in the database or some other mechanism to transport rather than git syncing them to API server. As I understand it the dashboard alert code runs on the api-server pods. So in order to adhere to the recommendation in the docs > When implementing dynamic alerts it is important to keep alert generation logic lightweight to avoid impacting dashboard load times. Consider caching results for expensive operations and handle exceptions gracefully to prevent alert generation from breaking the UI. I wanted to just run a subprocess command to get the githash from the currently deployed/synced git side-car. > Actually for security reasons the architecture wants to limit dependencies installed in API server. My initial assumption is this is why the api-server pods were not configured with this. So I made the option default to False. For our deployment there is minimal/no additional risk so we'd like to turn this feature True. Said another way, we would get a lot of value out of knowing exactly which githash/timestamp is currently deployed when we load the frontend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
