uranusjr commented on code in PR #52156: URL: https://github.com/apache/airflow/pull/52156#discussion_r2938342325
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -170,11 +170,14 @@ SIMPLE_AUTH_MANAGER = "SimpleAuthManager" FAB_AUTH_MANAGER = "FabAuthManager" +GOLANG_WORKER = "go" + DEFAULT_ALLOWED_EXECUTOR = ALLOWED_EXECUTORS[0] ALLOWED_AUTH_MANAGERS = [SIMPLE_AUTH_MANAGER, FAB_AUTH_MANAGER] START_AIRFLOW_ALLOWED_EXECUTORS = [LOCAL_EXECUTOR, CELERY_EXECUTOR, EDGE_EXECUTOR] START_AIRFLOW_DEFAULT_ALLOWED_EXECUTOR = START_AIRFLOW_ALLOWED_EXECUTORS[0] ALLOWED_CELERY_EXECUTORS = [CELERY_EXECUTOR, CELERY_K8S_EXECUTOR] +ALLOWED_WORKER_TYPES = [GOLANG_WORKER] Review Comment: Of course, a Python worker should be the default in any cases. I think the use case is only specifically to test-run functionalities in the Go SDK. Currently, the Go SDK requires you to use EdgeExecutor, and have a Go worker process running. The Python worker is not needed to execute Go tasks. It’s a very specific use case that only applies to dev (with Breeze), and honestly not even necessary (I can just leave the Python worker running idly). It would be good enough if there’s a way to automatically start the Go worker when EdgeExecutor is used. What I would want ideally ```bash --executor EdgeExecutor # Start a Python worker automatically. --executor EdgeExecutor --worker-type Python # Start a Python worker (explicit). --executor EdgeExecutor --worker-type Go # Start (only) a Go worker. --executor EdgeExecutor --worker-type Python --worker-type Go # Start two workers. ``` I don’t really mind CeleryExecutor for now (I believe the Go worker does not work with it currently), but we could do the same and add support later (I believe being able to run foreign language SDK in other executors is a planned feature anyway). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
