potiuk commented on PR #63533: URL: https://github.com/apache/airflow/pull/63533#issuecomment-4065615781
@yuseok89 This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :warning: **Testing requirements**: The two new tests (`test_execute_complete_success_returns_copied_files` and the updated `test_execute_complete_success`) both pass `context=mock.MagicMock()` without a `spec` or `autospec`. Per the code review checklist, unspecced mocks silently accept any attribute access and can hide real bugs. The context mock is inherited from the pre-existing test pattern, but the new test also follows the same unspecced pattern. > **Note:** Your branch is **67 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. - Maintainers will then proceed with a normal review. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
