choo121600 commented on code in PR #63463:
URL: https://github.com/apache/airflow/pull/63463#discussion_r2938738306
##########
airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts:
##########
@@ -129,54 +129,40 @@ export class EventsPage extends BasePage {
public async setFilterValue(filterLabel: string, value: string):
Promise<void> {
const filterPill = this.getFilterPill(filterLabel);
- if ((await filterPill.count()) > 0) {
+ if (await filterPill.isVisible()) {
await filterPill.click();
}
- // Wait for input to appear and fill it
- const filterInput = this.page.locator(`input[placeholder*="${filterLabel}"
i], input`).last();
+ const filterInput = this.page
+ .locator("div")
+ .filter({ hasText: `${filterLabel}:` })
+ .locator("input")
+ .first();
Review Comment:
Would it be possible to improve this using `this.page.getByRole()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
