choo121600 commented on code in PR #63516:
URL: https://github.com/apache/airflow/pull/63516#discussion_r2938931623
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
Review Comment:
Do we need the timeout here?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -128,6 +145,7 @@ export class ConnectionsPage extends BasePage {
}
// Check if a connection exists in the current view
+
public async connectionExists(connectionId: string): Promise<boolean> {
Review Comment:
`connectionExists` seems to be unused. Could we remove it?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -91,15 +93,23 @@ export class ConnectionsPage extends BasePage {
this.successAlert = page.locator('[data-scope="toast"][data-part="root"]');
// Delete confirmation dialog
- this.confirmDeleteButton =
page.locator('button:has-text("Delete")').first();
+ this.confirmDeleteButton = page.getByRole("button", { name: "Delete"
}).first();
this.rowsPerPageSelect = page.locator("select");
// Sorting and filtering
this.tableHeader = page.locator('[role="columnheader"]').first();
- this.connectionIdHeader = page.locator("th:has-text('Connection
ID')").first();
- this.connectionTypeHeader = page.locator('th:has-text("Connection
Type")').first();
- this.hostHeader = page.locator('th:has-text("Host")').first();
+ this.connectionIdHeader = page
Review Comment:
Would it be possible to improve this using `getByRole()`?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
Review Comment:
This pattern might introduce some flakiness, especially with the short
timeout and fallback typing. Could we make this more robust?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -42,6 +42,8 @@ export class ConnectionsPage extends BasePage {
public readonly connectionForm: Locator;
public readonly connectionIdHeader: Locator;
public readonly connectionIdInput: Locator;
+ // All table body rows (for web-first assertions in specs)
Review Comment:
This comment might not be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
