ferruzzi commented on code in PR #62645:
URL: https://github.com/apache/airflow/pull/62645#discussion_r2943081706
##########
airflow-core/src/airflow/executors/workloads/base.py:
##########
@@ -83,3 +83,59 @@ class BaseDagBundleWorkload(BaseWorkloadSchema, ABC):
dag_rel_path: os.PathLike[str] # Filepath where the DAG can be found
(likely prefixed with `DAG_FOLDER/`)
bundle_info: BundleInfo
log_path: str | None # Rendered relative log filename template the task
logs should be written to.
+
+ @property
+ @abstractmethod
+ def key(self) -> Any:
Review Comment:
Good call. I always forget about Hashable; it always feels too vague to be
useful, but his is the perfect spot for it. Thanks. In fact, I added the
WorkloadState TypeAlias so I can update a couple of other type hints
(success_state and failure_state, for starters) in here now as well. I'll
make a pass and see if I can narrow anything else down while I'm at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
