harishtheking commented on code in PR #63627:
URL: https://github.com/apache/airflow/pull/63627#discussion_r2943510609
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -387,7 +387,19 @@ def get_dag_runs(
This endpoint allows specifying `~` as the dag_id to retrieve Dag Runs for
all DAGs.
"""
- query = select(DagRun).options(*eager_load_dag_run_for_validation())
+ query = select(DagRun).options(
+ load_only(
Review Comment:
Thank you for the feedback!
My intention was to reduce unnecessary database loading for the list
endpoint by limiting the selected columns. However, I see that the API response
model (`DAGRunResponse`) expects all fields from `DagRun`, so restricting the
columns could potentially break the response.
I will take another look at the implementation and adjust the approach to
ensure compatibility with the response model. Thank you for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
