dondaum commented on PR #62164: URL: https://github.com/apache/airflow/pull/62164#issuecomment-4073758018
> I would wait for a maintainer to weigh in but the changes look fine to me. Ideally, these should be separate PRs as these changes are touching different part of airflow core but this PR is small enough that it is reviewable as is. I have left a comment for the test you have added. Also, one thing I am curious about is why you added a new test for one of the changes i.e. in `_get_code_from_db` but not the others? In my opinion the other changes are covered by unit tests. The change to `DagCode `has not been covered yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
