kaxil commented on code in PR #63617:
URL: https://github.com/apache/airflow/pull/63617#discussion_r2956811366
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -710,17 +711,16 @@ def _find_files_in_bundle(self, bundle: BaseDagBundle) ->
list[Path]:
return rel_paths
- def deactivate_deleted_dags(self, bundle_name: str, present:
set[DagFileInfo]) -> None:
- """Deactivate DAGs that come from files that are no longer present in
bundle."""
-
- def find_zipped_dags(abs_path: os.PathLike) -> Iterator[str]:
- """
- Find dag files in zip file located at abs_path.
+ def _get_observed_filelocs(self, present: set[DagFileInfo]) -> set[str]:
+ """
+ Return observed DAG source paths for bundle entries.
- We return the abs "paths" formed by joining the relative path
inside the zip
- with the path to the zip.
+ For regular files this includes the relative file path.
+ For ZIP archives this includes DAG-like inner paths such as
+ ``archive.zip/dag.py``.
+ """
- """
+ def find_zipped_dags(abs_path: os.PathLike) -> Iterator[str]:
Review Comment:
nit: The old `find_zipped_dags` had a docstring explaining it yields
absolute paths formed by joining the inner ZIP path with the ZIP file path.
That got dropped in the move to `_get_observed_filelocs`. A short docstring
like `"""Yield absolute paths for DAG-like files inside a ZIP archive."""`
would help readers understand what the yielded values represent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
