jason810496 commented on code in PR #63910:
URL: https://github.com/apache/airflow/pull/63910#discussion_r2957667117
##########
airflow-core/src/airflow/migrations/versions/0102_3_2_0_make_external_executor_id_text.py:
##########
@@ -27,49 +27,144 @@
from __future__ import annotations
+from typing import TYPE_CHECKING
+
import sqlalchemy as sa
from alembic import op
+if TYPE_CHECKING:
+ from sqlalchemy.engine import Connection
+
# revision identifiers, used by Alembic.
revision = "a5a3e5eb9b8d"
down_revision = "55297ae24532"
branch_labels = None
depends_on = None
airflow_version = "3.2.0"
+_TABLES = {"task_instance", "task_instance_history"}
+_COLUMN = "external_executor_id"
+_NEW_COL = "external_executor_id_new"
+_BATCH_SIZE = 1000
Review Comment:
```suggestion
_BATCH_SIZE = conf.getint("database", "migration_batch_size", fallback=1000)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
