dingo4dev commented on code in PR #62501:
URL: https://github.com/apache/airflow/pull/62501#discussion_r2958103726
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -230,7 +230,7 @@ def register_asset_change(
asset_event = AssetEvent(**event_kwargs)
session.add(asset_event)
- session.flush() # Ensure the event is written earlier than ADRQ
entries below.
+ session.commit() # Ensure the event is written earlier than ADRQ
entries below.
Review Comment:
if not populate immediately, there is a significant risk of orphaning this
event if a later `AssetDagRunQueue` entry created by another asset event (e.g.
Asset Alias) is processed by the scheduler first, resulting in a permanent
misfire for the original asset event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
