gnosyslambda opened a new pull request, #63914:
URL: https://github.com/apache/airflow/pull/63914
Fixes #63426
Cleaned up Playwright anti-patterns in `DagsPage.ts` and `dags-list.spec.ts`
to align with Playwright best practices. No test coverage or behavior changes —
just pattern improvements.
What changed:
- Removed 13 unnecessary `waitForTimeout()` calls, replaced with state-based
waiting or removed where a subsequent assertion already covers it
- Replaced `:has-text()` CSS selectors with `getByRole()` / `getByText()` /
`.filter({ hasText })` (8 occurrences)
- Converted manual boolean assertions (try/catch returning true/false) to
direct web-first assertions
- Replaced `dispatchEvent("click")` with `.click()`
- Replaced legacy `text=` locators with `getByText()`
All changes follow the same patterns used in the already-merged PRs for
other spec files (#63079, #63112, #63415).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
