potiuk commented on code in PR #63868:
URL: https://github.com/apache/airflow/pull/63868#discussion_r2959352194
##########
providers/fab/pyproject.toml:
##########
@@ -70,10 +70,7 @@ dependencies = [
# Blinker use for signals in Flask, this is an optional dependency in
Flask 2.2 and lower.
# In Flask 2.3 it becomes a mandatory dependency, and flask signals are
always available.
"blinker>=1.6.2",
- # Flask 2.3 is scheduled to introduce a number of deprecation removals -
some of them might be breaking
- # for our dependencies - notably `_app_ctx_stack` and `_request_ctx_stack`
removals.
- # We should remove the limitation after 2.3 is released and our
dependencies are updated to handle it
- "flask>=2.2.1,<2.3",
+ "flask>=2.2.1",
Review Comment:
Let's do it in stages.
* Let's change it here by removing the limits. Current constraints show
`Flask==2.2.5` so `<2.3` is not the reason now
* We need to look up what's blocking us - then we see what we do next to
possbily get to flask 3 (but we will have to know consequences - there are some
edge cases, where lower-binding one dependecy will downgrade another - because
for example newer version of that dependensy has upper-limit, and lower version
did not have that limit defined (but it is still not compatible) .
* Then - if we see that it is safe- I am all for > 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
