sg-c0de commented on PR #63514: URL: https://github.com/apache/airflow/pull/63514#issuecomment-4089729219
Thanks for the review feedback! Here's what I've addressed: ### Tests added: Added `test_worker_image.py` with 24 tests covering: - Default image behavior (no override, global `images.airflow` override) - `workers.celery.image` overrides (full, partial repository/tag, digest precedence) - Per-set image overrides (`workers.celery.sets[].image`) including full overwrite - imagePullPolicy at celery and per-set levels - `wait-for-airflow-migrations` init container image behavior with useDefaultImageForMigration - Container consistency (worker, log-groomer, kerberos containers) ### Description vs code mismatch clarified: Updated the airflow_worker_image helper comment in _helpers.yaml to explain the merge indirection: users configure at Values.workers.celery.image, but workersMergeValues in worker-deployment.yaml promotes it to Values.workers.image before the helper runs. All 24 tests pass locally. Branch has been rebased onto main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
