xBis7 commented on code in PR #63932:
URL: https://github.com/apache/airflow/pull/63932#discussion_r2960997001
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -179,70 +174,36 @@ def set_metrics(
EdgeWorkerState.OFFLINE_MAINTENANCE,
)
- if DualStatsManager is not None:
- DualStatsManager.gauge(
- "edge_worker.connected",
- int(connected),
- tags={},
- extra_tags={"worker_name": worker_name},
- )
-
- DualStatsManager.gauge(
- "edge_worker.maintenance",
- int(maintenance),
- tags={},
- extra_tags={"worker_name": worker_name},
- )
-
- DualStatsManager.gauge(
- "edge_worker.jobs_active",
- jobs_active,
- tags={},
- extra_tags={"worker_name": worker_name},
- )
-
- DualStatsManager.gauge(
- "edge_worker.concurrency",
- concurrency,
- tags={},
- extra_tags={"worker_name": worker_name},
- )
-
- DualStatsManager.gauge(
- "edge_worker.free_concurrency",
- free_concurrency,
- tags={},
- extra_tags={"worker_name": worker_name},
- )
-
- DualStatsManager.gauge(
- "edge_worker.num_queues",
- len(queues),
- tags={},
- extra_tags={"worker_name": worker_name, "queues":
",".join(queues)},
- )
- else:
- Stats.gauge(f"edge_worker.connected.{worker_name}", int(connected))
- Stats.gauge("edge_worker.connected", int(connected),
tags={"worker_name": worker_name})
-
- Stats.gauge(f"edge_worker.maintenance.{worker_name}", int(maintenance))
- Stats.gauge("edge_worker.maintenance", int(maintenance),
tags={"worker_name": worker_name})
-
- Stats.gauge(f"edge_worker.jobs_active.{worker_name}", jobs_active)
- Stats.gauge("edge_worker.jobs_active", jobs_active,
tags={"worker_name": worker_name})
-
- Stats.gauge(f"edge_worker.concurrency.{worker_name}", concurrency)
- Stats.gauge("edge_worker.concurrency", concurrency,
tags={"worker_name": worker_name})
-
- Stats.gauge(f"edge_worker.free_concurrency.{worker_name}",
free_concurrency)
- Stats.gauge("edge_worker.free_concurrency", free_concurrency,
tags={"worker_name": worker_name})
-
- Stats.gauge(f"edge_worker.num_queues.{worker_name}", len(queues))
- Stats.gauge(
- "edge_worker.num_queues",
- len(queues),
- tags={"worker_name": worker_name, "queues": ",".join(queues)},
- )
+ Stats.gauge(
+ "edge_worker.connected",
+ int(connected),
+ legacy_name_tags={"worker_name": worker_name},
+ )
+ Stats.gauge(
+ "edge_worker.maintenance",
+ int(maintenance),
+ legacy_name_tags={"worker_name": worker_name},
+ )
+ Stats.gauge(
+ "edge_worker.jobs_active",
+ jobs_active,
+ legacy_name_tags={"worker_name": worker_name},
+ )
+ Stats.gauge(
+ "edge_worker.concurrency",
+ concurrency,
+ legacy_name_tags={"worker_name": worker_name},
+ )
+ Stats.gauge(
Review Comment:
ooh I see.
Now it's
```
if version >= 3.2:
DualStatsManager.incr(...
else:
Stats.incr(...
```
but it should be
```
if version >= 3.2:
stats.incr(...
else:
Stats.incr(...
```
and the shims in core and sdk should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
