jason810496 commented on code in PR #63920:
URL: https://github.com/apache/airflow/pull/63920#discussion_r2964389607
##########
airflow-core/src/airflow/migrations/versions/0101_3_2_0_ui_improvements_for_deadlines.py:
##########
@@ -74,6 +75,83 @@
DEFAULT_BATCH_SIZE = 1000
ENCODING_TYPE = "deadline_alert"
+
+def _has_matching_index(conn: Connection, table_name: str, columns:
Iterable[str]) -> bool:
+ log.debug("Targeting index check", table=table_name, columns=list(columns))
+ target_columns = list(columns)
+ inspector = sa.inspect(conn)
Review Comment:
I just checked that we already had warning and return for the offline mode
at the beginning of `migrate_existing_deadline_alert_data_from_serialized_dag`
upgrade path:
https://github.com/apache/airflow/blob/42ea52cf97804353fd60551df3f33235f2c5d572/airflow-core/src/airflow/migrations/versions/0101_3_2_0_ui_improvements_for_deadlines.py#L467-L477
We will create the table but not migrate the data in offline mode, so I
think we're good here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
