Lee-W commented on code in PR #63848:
URL: https://github.com/apache/airflow/pull/63848#discussion_r2964511738


##########
airflow-core/tests/unit/assets/test_manager.py:
##########
@@ -294,3 +294,24 @@ def test_register_asset_change_queues_stale_dag(self, 
session, mock_task_instanc
 
         queued_id = session.scalar(select(AssetDagRunQueue.target_dag_id))
         assert queued_id == "stale_dag"
+
+    @pytest.mark.usefixtures("clear_assets", "testing_dag_bundle")
+    def 
test_partitioned_asset_event_does_not_trigger_non_partitioned_dag(self, 
session, mock_task_instance):
+        """Issue #63734: partitioned asset events must not queue 
non-partition-aware DAGs."""

Review Comment:
   ```suggestion
           """partitioned asset events (events with partition key) must not 
queue non-partition-aware Dags."""
   ```



##########
airflow-core/newsfragments/63848.bugfix.rst:
##########
@@ -0,0 +1 @@
+Fix partitioned asset events incorrectly triggering DAGs that are not 
partition-aware.

Review Comment:
   The whole asset partition thing is a new feature to Airflow and not yet 
released. so I don't think we need it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to