anishgirianish commented on code in PR #62343: URL: https://github.com/apache/airflow/pull/62343#discussion_r2971221961
########## airflow-core/src/airflow/executors/local_executor.py: ########## Review Comment: Hi @jscheffl, for every executor to invoke connection test execution, I tried moving the logic out of local_executor.py into executors/workloads/connection_test.py as a shared, executor-agnostic function. This seems like the ideal location since workloads run on workers. However, this causes the check-sdk-imports hook to fail because the function needs from airflow.sdk.api.client import Client to communicate results via the Execution API. Would appreciate your suggestions on how to handle this. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
