Bhuvan-08 commented on code in PR #63474:
URL: https://github.com/apache/airflow/pull/63474#discussion_r2971326811
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ProvidersPage.ts:
##########
@@ -39,47 +39,13 @@ export class ProvidersPage extends BasePage {
return this.rows.count();
}
- public async getRowDetails(index: number) {
- const row = this.rows.nth(index);
- const cells = row.locator("td");
-
- const pkg = await cells.nth(0).locator("a").textContent();
- const ver = await cells.nth(1).textContent();
- const desc = await cells.nth(2).textContent();
-
- return {
- description: (desc ?? "").trim(),
- packageName: (pkg ?? "").trim(),
- version: (ver ?? "").trim(),
- };
- }
-
public async navigate(): Promise<void> {
await this.navigateTo("/providers");
}
public async waitForLoad(): Promise<void> {
await this.table.waitFor({ state: "visible", timeout: 30_000 });
- await this.waitForTableData();
- }
-
- private async waitForTableData(): Promise<void> {
- // Wait for actual data links to appear (not skeleton loaders)
- await this.page.waitForFunction(
- () => {
- const table = document.querySelector('[data-testid="table-list"]');
-
- if (!table) {
- return false;
- }
-
- // Check for actual links in tbody (real data, not skeleton)
- const links = table.querySelectorAll("tbody tr td a");
-
- return links.length > 0;
- },
- undefined,
- { timeout: 30_000 },
- );
+ await this.table.locator("tbody tr").first().waitFor({ state: "visible",
timeout: 30_000 });
+ await this.table.locator("tbody tr td a").first().waitFor({ state:
"visible", timeout: 30_000 });
Review Comment:
I just pushed a commit swapping those out for idiomatic await
expect(...).toBeVisible() calls. Let me know if this looks better! Let me know
if anything else has to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
