jscheffl opened a new pull request, #64076: URL: https://github.com/apache/airflow/pull/64076
We see longer lasting locks in our production and following the (a bit pending) discussion in Slack (https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1774011646300199) we consider the two steps of `adopt_or_reset_orphaned_tasks()` to (1) mark tasks and (2) process tasks might be causing a long lasting lock on the `job` table. First statement is "just" marking all tasks which are missing heartbeats and then the non heartbeat tasks are looped through to handle the failure. As the second step can take a longer time, rows on the `job`table stay with a lock and other processes might queue up on this - especially if multiple schedulers run in parallel. Therefore proposing to add a commit() as (1) the both parts are logically independent and (2) a potential lock is immediately released. But it might be conflicting to error handling in PSQL OperationalError handling and retry... --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
