SameerMesiah97 commented on code in PR #63781:
URL: https://github.com/apache/airflow/pull/63781#discussion_r2972071807
##########
airflow-core/tests/unit/utils/test_db_cleanup.py:
##########
@@ -741,6 +741,16 @@ def test_drop_archived_tables(self, mock_input,
confirm_mock, inspect_mock, capl
else:
confirm_mock.assert_not_called()
+ def test_export_archived_records_positional_fails(self):
Review Comment:
I don't have a strong opinion against including these tests but aren't they
just testing python's built-in behavior when `*` is added to the method
signature?
##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -621,6 +621,7 @@ def run_cleanup(
def export_archived_records(
export_format: str,
output_path: str,
+ *,
table_names: list[str] | None = None,
drop_archives: bool = False,
needs_confirm: bool = True,
Review Comment:
Why did you only make a subset of the parameters keyword-only for this
method when you made all parameters for `drop_archived_tables` keyword-only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
