uranusjr commented on code in PR #64089:
URL: https://github.com/apache/airflow/pull/64089#discussion_r2973020591
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/backfills.py:
##########
@@ -54,6 +54,8 @@ class BackfillResponse(BaseModel):
completed_at: datetime | None
updated_at: datetime
dag_display_name: str = Field(validation_alias=AliasPath("dag_model",
"dag_display_name"))
+ num_runs: int = 0
+ dag_run_state_counts: dict[str, int] = {}
Review Comment:
This probably should not be `= {}`
Why do these fields need a default value?
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/backfills.py:
##########
@@ -54,6 +54,8 @@ class BackfillResponse(BaseModel):
completed_at: datetime | None
updated_at: datetime
dag_display_name: str = Field(validation_alias=AliasPath("dag_model",
"dag_display_name"))
+ num_runs: int = 0
+ dag_run_state_counts: dict[str, int] = {}
Review Comment:
This probably should not be `= {}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
