jedcunningham commented on code in PR #64083:
URL: https://github.com/apache/airflow/pull/64083#discussion_r2973158942


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -918,8 +937,19 @@ Update "Announcements" page at the [Official Airflow 
website](https://airflow.ap
 
 Create a new release on GitHub with the release notes and assets from the 
release svn.
 
+For this to make use the following:
+
+- Draft a new release in https://github.com/apache/airflow/releases/new

Review Comment:
   ```suggestion
   - Create a new release in https://github.com/apache/airflow/releases/new
   ```
   
   Let's not use "Draft" since you can actually create a draft release :)



##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -843,7 +862,7 @@ workflow in `airflow-site` repository. Make sure to use 
`main` branch.
 You can check the latest chart version that is in the `index.yaml` with:
 
 ```shell
-curl -s https://airflow.apache.org/index.yaml | yq e 
'.entries.airflow[0].version' -
+curl -s https://airflow.apache.org/index.yaml | yq -e 
'.entries.airflow[0].version' -

Review Comment:
   `e` is for eval, not `-e` which sets the exit status (not really necessary 
in this context).
   
   It can also be dropped.
   
   ```suggestion
   curl -s https://airflow.apache.org/index.yaml | yq 
'.entries.airflow[0].version' -
   ```



##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -929,6 +959,12 @@ make sure to update the last updated timestamp as well.
 
 Don't forget to thank the folks who tested and close the issue tracking the 
testing status.
 
+```
+Thank you everyone. New Helm-Chart is released.
+
+I invite everyone to help improve providers for the next release, a list of 
open issues can be found 
[here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).

Review Comment:
   ```suggestion
   I invite everyone to help improve the chart for the next release, a list of 
open issues can be found 
[here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to