jason810496 commented on issue #60000: URL: https://github.com/apache/airflow/issues/60000#issuecomment-4115039727
> > Hey [@sunank200](https://github.com/sunank200). One question about this one. I just found out that this PR might introduce one small regression. And by looking at the different PRs I think you also experienced it. These PRs causes the test to no longer load default values from provider configuration. Examples: > > > > * In [Amazon provider package PR](https://github.com/apache/airflow/pull/59979) you needed to add multiple times `fallback` even though this configuration has a default value configured > > * In [elasticsearch](https://github.com/apache/airflow/pull/60030/files) as well > > > > Do you know why? And is it intended? > > Yes this is a regression. > > As [@jason810496](https://github.com/jason810496) mentioned, the full context and correct way to fix it are described in this comment: [#60074 (comment)](https://github.com/apache/airflow/pull/60074#issuecomment-3711902451) Hi all, The issue is now unblocked; there is no more need for an explicit fallback, as [Make TaskSDK conf respect default config from provider metadata #62696](https://github.com/apache/airflow/pull/62696) just merged yesterday. We can continue with the rest of the provider migrations, and maybe it is worthwhile to double-check and clean up the above regression (adding a manual explicit `fallback` during the migration) that was pointed out by @vincbeck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
