jason810496 commented on code in PR #64138:
URL: https://github.com/apache/airflow/pull/64138#discussion_r2979310612
##########
scripts/ci/prek/check_cli_definition_imports.py:
##########
@@ -39,10 +39,7 @@
from common_prek_utils import console, get_imports_from_file
# Allowed modules that can be imported in CLI definition files
-ALLOWED_MODULES = {
- "airflow.configuration",
- "airflow.cli.cli_config",
-}
+ALLOWED_MODULES = {"airflow.configuration", "airflow.cli.cli_config",
"airflow.providers.common.compat.sdk"}
Review Comment:
Would it be possible to only allow `conf` being imported from
`airflow.providers.common.compat.sdk`?
Since allowing all the module being imported from
`airflow.providers.common.compat.sdk` might be too broad for this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
