mwojtyczka commented on code in PR #63775:
URL: https://github.com/apache/airflow/pull/63775#discussion_r2980233436
##########
providers/databricks/src/airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -296,9 +322,7 @@ async def _a_get_sp_token(self, resource: str) -> str:
with attempt:
async with self._session.post(
resource,
- auth=aiohttp.BasicAuth(
- self._get_connection_attr("login"),
self.databricks_conn.password
Review Comment:
`_get_connection_attr("login")` was replaced with `conn.login or ""`.
`_get_connection_attr` raises `ValueError` if login is falsy. But conn.login or
"" silently substitutes an empty string. This changes error behaviour — a
missing login silently passes an empty string to aiohttp.BasicAuth, which will
probably fail with a cryptic auth error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
