Karthikeya1500 opened a new pull request, #64182:
URL: https://github.com/apache/airflow/pull/64182
Clicking on a pool slot segment (e.g. running or queued) in the Pools page
navigates to `/task_instances` but the state and pool filters don't get
applied. The task instances page shows unfiltered results instead.
The root cause is that `PoolBar.tsx` uses `SearchParamsKeys.STATE` (`state`)
and `SearchParamsKeys.POOL` (`pool`), but the `TaskInstances` page actually
reads from `SearchParamsKeys.TASK_STATE` (`task_state`) and
`SearchParamsKeys.POOL_NAME_PATTERN` (`pool_name_pattern`). The parameter name
mismatch causes the filters to be silently ignored.
I also noticed `slot.color` was being used as the state value instead of
`slot.slotType`. They happen to match for non-open slots right now, but
`slotType` is the semantically correct value to pass as a task instance state
filter.
```diff
-
to={`/task_instances?${SearchParamsKeys.STATE}=${slot.color}&${SearchParamsKeys.POOL}=${pool.name}`}
+
to={`/task_instances?${SearchParamsKeys.TASK_STATE}=${slot.slotType}&${SearchParamsKeys.POOL_NAME_PATTERN}=${pool.name}`}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
