Pranaykarvi commented on PR #63915: URL: https://github.com/apache/airflow/pull/63915#issuecomment-4133804758
Hi @SameerMesiah97, addressed all your review comments: - Replaced fallback `get_pod()` calls with a list comprehension over `current_pods` - Removed `run_in_executor` mock and re-initialized `GKEJobTrigger` block; using `job_trigger` fixture with `do_xcom_push = True` instead - Collapsed redundant `extract_xcom` asserts into `assert_called_once_with(succeeded_pod)` - Added `wait_until_container_complete` and `wait_until_container_started` assertions on `retry-succeeded-pod` - Added blank lines for readability All changes pass `ruff format` and `ruff check --fix`. Please take another look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
